refactor agents to client-owned config flow

app/core/agent_runner.py

@@ -238,17 +238,23 @@ async def run_local_agent(
     run_id = run_log.id
 
     # ── 1. Device online check ─────────────────────────────────────────
-    if not device_mgr.is_online(user_id, config.device_id):
+    target_device_id = config.device_id.strip() if isinstance(config.device_id, str) else ""
+    if target_device_id:
+        is_online = device_mgr.is_online(user_id, target_device_id)
+    else:
+        is_online = device_mgr.is_online(user_id)
+
+    if not is_online:
         logger.info(
             "agent_runner: skip run=%s — device %r offline for user=%s",
             run_id,
-            config.device_id,
+            target_device_id or "<any>",
             user_id,
         )
         await _finalize_run(
             run_log,
             status="error",
-            errors=[f"Device {config.device_id!r} is not connected"],
+            errors=[f"Device {target_device_id or '<any>'!r} is not connected"],
         )
         return
 
@@ -369,7 +375,7 @@ async def run_local_agent(
         items_processed=items_processed,
         items_created=items_created,
         errors=errors,
-        update_config_last_run=True,
+        update_config_last_run=False,
         config_id=config.id,
         config_type="local",
     )
@@ -610,60 +616,11 @@ async def trigger_pending_runs(
     * Runs execute **sequentially** to avoid flooding the WS connection.
     """
     logger.info(
-        "agent_runner: scanning overdue runs for user=%s device=%s", user_id, device_id
+        "agent_runner: pending-run scan skipped for user=%s device=%s (client-owned agent config)",
+        user_id,
+        device_id,
     )
-    async with async_session() as db:
-        local_result = await db.execute(
-            select(LocalAgentConfig).where(
-                LocalAgentConfig.user_id == user_id,
-                LocalAgentConfig.enabled == True,  # noqa: E712
-                LocalAgentConfig.device_id == device_id,
-            )
-        )
-        local_configs: list[LocalAgentConfig] = list(local_result.scalars().all())
-
-        cloud_result = await db.execute(
-            select(CloudAgentConfig).where(
-                CloudAgentConfig.user_id == user_id,
-                CloudAgentConfig.enabled == True,  # noqa: E712
-            )
-        )
-        cloud_configs: list[CloudAgentConfig] = list(cloud_result.scalars().all())
-
-    # Build ordered list of overdue (type, config) pairs.
-    pending: list[tuple[str, Any]] = []
-    for cfg in local_configs:
-        if _is_overdue(cfg.schedule_cron, cfg.last_run_at):
-            pending.append(("local", cfg))
-    for cfg in cloud_configs:
-        if _is_overdue(cfg.schedule_cron, cfg.last_run_at):
-            pending.append(("cloud", cfg))
-
-    if not pending:
-        logger.debug("agent_runner: no overdue runs for user=%s", user_id)
-        return
-
-    logger.info(
-        "agent_runner: %d overdue run(s) to dispatch for user=%s", len(pending), user_id
-    )
-
-    for agent_type, cfg in pending:
-        # Create a fresh run log for this scheduled dispatch.
-        run_log = AgentRunLog(
-            agent_id=cfg.id,
-            agent_type=agent_type,
-            user_id=user_id,
-            status="running",
-        )
-        async with async_session() as db:
-            db.add(run_log)
-            await db.commit()
-            await db.refresh(run_log)
-
-        if agent_type == "local":
-            await run_local_agent(user_id, cfg, run_log, device_mgr)
-        else:
-            await run_cloud_agent(user_id, cfg, run_log, device_mgr)
+    return
 
 
 # ── Internal helper ─────────────────────────────────────────────────────────