diff --git a/requirements.txt b/requirements.txt
index 6a7b5a6..ff06d05 100644
--- a/requirements.txt
+++ b/requirements.txt
@@ -35,4 +35,5 @@ cryptography>=42.0.0
langfuse>=2.0.0
beautifulsoup4>=4.12.0
lxml>=5.0.0
+PyYAML>=6.0.0
ruff>=0.8.0
diff --git a/tests/fixtures/preprocessors/cases.yaml b/tests/fixtures/preprocessors/cases.yaml
new file mode 100644
index 0000000..f40e84b
--- /dev/null
+++ b/tests/fixtures/preprocessors/cases.yaml
@@ -0,0 +1,127 @@
+# Preprocessor test cases — Step 1 (Local Agent V2)
+#
+# Schema per caso:
+# id: "1.N"
+# description: str
+# score_name: str # nome score inviato a Langfuse
+#
+# Sorgente contenuto (una delle due):
+# file: Fix the login bug
+
+
+
+
+
+
Hi,
+
Please fix the login bug by Friday. It is blocking the release.
+
Priority: high. Let me know if you need anything.
+
Thanks,
+
+
+
+
+ From:
+ newsletter@corp.com
+
+
+ Subject:
+ Q1 Results Update
+
+
+ Date:
+ Apr 7, 2026
+
+
+
+
+
+
+ Dear Team,
+ Q1 results are in. Revenue up 15% year-over-year.
+ Please review the attached report and share any feedback by EOW.
+
+
+
+
+
+
+
+
+
+
diff --git a/tests/fixtures/preprocessors/data/email_single.html b/tests/fixtures/preprocessors/data/email_single.html
new file mode 100644
index 0000000..bc4358d
--- /dev/null
+++ b/tests/fixtures/preprocessors/data/email_single.html
@@ -0,0 +1,8 @@
+
+
+ From: alice@co.com
+ To: team@co.com
+ Subject: Quick update
+ Date: Tue, 7 Apr 2026 10:30:00 +0200
+ The deploy is done. Everything looks good. No issues so far.
+
diff --git a/tests/fixtures/preprocessors/data/email_thread.html b/tests/fixtures/preprocessors/data/email_thread.html
new file mode 100644
index 0000000..0ba94a1
--- /dev/null
+++ b/tests/fixtures/preprocessors/data/email_thread.html
@@ -0,0 +1,24 @@
+
+
+
+
From: alice@co.com
+
Subject: Re: Re: Deploy plan
+
Sure, I'll handle the deploy.
+
On Mon, Apr 6, 2026 at 3:00 PM, Bob <bob@co.com> wrote:
+
+ From: bob@co.com
+ Can you handle the deploy?
+ On Sun, Apr 5, 2026 at 1:00 PM, Alice <alice@co.com> wrote:
+
+ From: alice@co.com
+ Let's plan the deploy for Monday.
+ On Sat, Apr 4, 2026 at 11:00 AM, Charlie <charlie@co.com> wrote:
+
+ From: charlie@co.com
+ We need to schedule the deploy. What day works?
+
+
+
+
diff --git a/tests/fixtures/preprocessors/data/fallback.txt b/tests/fixtures/preprocessors/data/fallback.txt
new file mode 100644
index 0000000..ce461b9
--- /dev/null
+++ b/tests/fixtures/preprocessors/data/fallback.txt
@@ -0,0 +1,3 @@
+random text content without any structure
+line two with some words
+line three and more content here
diff --git a/tests/fixtures/preprocessors/data/generic_page.html b/tests/fixtures/preprocessors/data/generic_page.html
new file mode 100644
index 0000000..edfe8a3
--- /dev/null
+++ b/tests/fixtures/preprocessors/data/generic_page.html
@@ -0,0 +1,35 @@
+
+
+
+ My Web App
+
+ Home
+ About
+ Contact
+
+
+
+
+ This is a generic web page with no email headers.
+ It has navigation, main content, and a footer.
+
+
+ Features
+
+ Fast
+ Reliable
+ Secure
+
+
+
+
+
+
diff --git a/tests/fixtures/preprocessors/data/notes.txt b/tests/fixtures/preprocessors/data/notes.txt
new file mode 100644
index 0000000..4a66216
--- /dev/null
+++ b/tests/fixtures/preprocessors/data/notes.txt
@@ -0,0 +1,15 @@
+Meeting notes - April 7, 2026
+
+Attendees: Alice, Bob, Charlie
+
+Discussion points:
+- Deploy scheduled for Friday
+- Bug fix for login must be completed by Thursday
+- Review Q1 numbers before EOW
+
+Action items:
+- Alice: fix login bug
+- Bob: prepare deploy checklist
+- Charlie: send Q1 report
+
+Next meeting: April 14, 2026
diff --git a/tests/test_preprocessors.py b/tests/test_preprocessors.py
index 83b68cd..00dcff8 100644
--- a/tests/test_preprocessors.py
+++ b/tests/test_preprocessors.py
@@ -1,221 +1,178 @@
-"""Tests for the preprocessor system (Step 1).
+"""Tests for the preprocessor system (Step 1 — Local Agent V2).
-Test IDs map to the plan:
- 1.1 detect_email, 1.2 detect_generic, 1.3 detect_text, 1.4 detect_unknown
- 1.5 email_strip, 1.6 email_metadata, 1.7 email_thread, 1.8 email_single
- 1.9 email_heavy_html, 1.10 fallback
+Fixtures are driven by:
+ tests/fixtures/preprocessors/cases.yaml — test case definitions
+ tests/fixtures/preprocessors/data/ — input files (HTML, txt, ...)
Run:
pytest tests/test_preprocessors.py -v
+ # Only detection tests
+ pytest tests/test_preprocessors.py -v -k detect
+
+ # Only preprocess tests
+ pytest tests/test_preprocessors.py -v -k preprocess
+
Langfuse scores are sent when LANGFUSE_SECRET_KEY / LANGFUSE_PUBLIC_KEY are set.
"""
from __future__ import annotations
+import re
+from pathlib import Path
+from typing import Any
+
import pytest
+import yaml
-from app.core.preprocessors import detect_content_type, preprocess
from app.core.langfuse_client import get_langfuse
+from app.core.preprocessors import detect_content_type, preprocess
-# ── Fixtures ──────────────────────────────────────────────────────────
+# ── Paths ──────────────────────────────────────────────────────────────
+
+_FIXTURES_DIR = Path(__file__).parent / "fixtures" / "preprocessors"
+_DATA_DIR = _FIXTURES_DIR / "data"
+_CASES_FILE = _FIXTURES_DIR / "cases.yaml"
+
+# ── Content generators ─────────────────────────────────────────────────
+
+_GENERATORS: dict[str, str] = {
+ # High ratio of non-printable chars → triggers "unknown" heuristic
+ "binary_noise": "some\x00\x01\x02\x03\x04\x05content" * 20,
+}
-@pytest.fixture
-def sample_email_html() -> str:
- return """
-
-
- Fix the login bug
-
-
-
- Subject: Fix the login bug
- From: boss@company.com
- To: dev@company.com
- Date: Mon, 7 Apr 2026 09:00:00 +0200
- Please fix the login bug by Friday. It is blocking the release.
-
-"""
+def _load_cases() -> list[dict]:
+ with _CASES_FILE.open(encoding="utf-8") as f:
+ return yaml.safe_load(f)["cases"]
-@pytest.fixture
-def sample_thread_email_html() -> str:
- return """
-
-From: alice@co.com
-Subject: Re: Re: Deploy plan
-Sure, I'll handle the deploy.
-
-On Mon, Apr 6, 2026 at 3:00 PM, Bob <bob@co.com> wrote:
-
-From: bob@co.com
-Can you handle the deploy?
-On Sun, Apr 5, 2026 at 1:00 PM, Alice <alice@co.com> wrote:
-
-From: alice@co.com
-Let's plan the deploy for Monday.
-
-
-"""
+def _read_content(case: dict) -> str:
+ if "generate" in case:
+ key = case["generate"]
+ if key not in _GENERATORS:
+ raise ValueError(f"Unknown generator '{key}' in case {case['id']}")
+ return _GENERATORS[key]
+ file_path = _DATA_DIR / case["file"]
+ return file_path.read_text(encoding="utf-8")
-@pytest.fixture
-def sample_heavy_html_email() -> str:
- return """
-
-
-
-
-
- From: newsletter@corp.com Subject: Q1 Results Update Date: Apr 7, 2026
- Dear Team,
- Q1 results are in. Revenue up 15% year-over-year.
- Please review the attached report.
-
-"""
+# ── Langfuse helper ───────────────────────────────────────────────────
-
-# ── Helper ────────────────────────────────────────────────────────────
-
-def _score(name: str, value: float, comment: str = "") -> None:
+def _lf_score(score_name: str, value: float, comment: str = "") -> None:
lf = get_langfuse()
if lf:
- trace = lf.trace(name=f"eval-{name}")
- lf.score(trace_id=trace.id, name=name, value=value,
- data_type="NUMERIC", comment=comment)
+ trace = lf.trace(name=f"eval-{score_name}")
+ lf.score(
+ trace_id=trace.id,
+ name=score_name,
+ value=value,
+ data_type="NUMERIC",
+ comment=comment,
+ )
lf.flush()
-# ── 1.1 — Detect email HTML ───────────────────────────────────────────
+# ── Assertion engine ──────────────────────────────────────────────────
-def test_detect_email_html(sample_email_html):
- ct = detect_content_type("email_export.html", sample_email_html)
- score = 1.0 if ct == "email_html" else 0.0
- _score("preprocess.detect_email", score)
- assert ct == "email_html", f"Expected 'email_html', got '{ct}'"
+def _run_assertions(assertions: dict[str, Any], result: Any, raw: str) -> tuple[float, list[str]]:
+ """Run all assertions declared in the YAML case.
+
+ Returns (score 0.0–1.0, list of failure messages).
+ """
+ failures: list[str] = []
+
+ if assertions.get("no_html_tags"):
+ if re.search(r"<[^>]+>", result.clean_text):
+ failures.append("clean_text still contains HTML tags")
+
+ min_len = assertions.get("min_length")
+ if min_len is not None:
+ if len(result.clean_text) < min_len:
+ failures.append(
+ f"clean_text too short: {len(result.clean_text)} < {min_len}"
+ )
+
+ ratio_lt = assertions.get("compression_ratio_lt")
+ if ratio_lt is not None and len(raw) > 0:
+ ratio = len(result.clean_text) / len(raw)
+ if ratio >= ratio_lt:
+ failures.append(f"compression ratio {ratio:.2f} >= {ratio_lt}")
+
+ meta_keys = assertions.get("metadata_keys", [])
+ for key in meta_keys:
+ if not result.metadata.get(key):
+ failures.append(f"metadata missing key '{key}' (got {result.metadata})")
+
+ contains = assertions.get("contains")
+ if contains:
+ items = [contains] if isinstance(contains, str) else contains
+ for item in items:
+ if item not in result.clean_text:
+ failures.append(f"clean_text missing expected substring: {item!r}")
+
+ not_contains = assertions.get("not_contains")
+ if not_contains:
+ items = [not_contains] if isinstance(not_contains, str) else not_contains
+ for item in items:
+ if item in result.clean_text:
+ failures.append(f"clean_text contains forbidden substring: {item!r}")
+
+ expected_ct = assertions.get("content_type")
+ if expected_ct and result.content_type != expected_ct:
+ failures.append(
+ f"content_type mismatch: expected {expected_ct!r}, got {result.content_type!r}"
+ )
+
+ score = 1.0 if not failures else 0.0
+ return score, failures
-# ── 1.2 — Detect generic HTML ─────────────────────────────────────────
+# ── Parametrized: detect ──────────────────────────────────────────────
-def test_detect_generic_html():
- generic = """My App
-Home Welcome
From: alice@co.com
-Subject: Quick update
-The deploy is done. Everything looks good.
-"""
- result = preprocess("email_html", single)
- has_body = "deploy is done" in result.clean_text
- score = 1.0 if has_body else 0.0
- _score("preprocess.email_single", score)
- assert has_body, "Body of single message not found in clean_text"
-
-
-# ── 1.9 — Email: heavy HTML (table layout) ───────────────────────────
-
-def test_email_heavy_html(sample_heavy_html_email):
- result = preprocess("email_html", sample_heavy_html_email)
- has_no_tags = "<" not in result.clean_text
- has_content = len(result.clean_text) > 30
- # CSS properties should not appear in clean text
- no_css = "border-collapse" not in result.clean_text and "font-size" not in result.clean_text
- score = 1.0 if (has_no_tags and has_content and no_css) else 0.0
- _score("preprocess.email_heavy_html", score,
- f"no_tags={has_no_tags}, has_content={has_content}, no_css={no_css}")
- assert has_no_tags, "HTML tags found in clean_text"
- assert has_content, "clean_text is empty"
- assert no_css, "CSS properties leaked into clean_text"
-
-
-# ── 1.10 — Fallback: unknown file type ───────────────────────────────
-
-def test_fallback_unknown_content():
- raw = "random text content without any structure\nline two\nline three"
- result = preprocess("unknown", raw)
- has_text = len(result.clean_text) > 0
- score = 1.0 if has_text else 0.0
- _score("preprocess.fallback", score)
- assert has_text, "fallback handler returned empty clean_text"
- assert result.content_type == "unknown"
+ assert not failures, (
+ f"[{case['id']}] {case['description']} — {len(failures)} assertion(s) failed:\n"
+ + "\n".join(f" • {f}" for f in failures)
+ )