fix
Some checks failed
Release Electron App / release-desktop (push) Failing after 8m6s

This commit is contained in:
2026-03-03 23:26:41 +01:00
parent 5170f10b64
commit 1aa315cddf

View File

@@ -79,27 +79,57 @@ const config: ForgeConfig = {
fs.readFileSync(path.resolve(__dirname, 'node_modules', 'electron', 'package.json'), 'utf-8'), fs.readFileSync(path.resolve(__dirname, 'node_modules', 'electron', 'package.json'), 'utf-8'),
).version; ).version;
// Clean stale build artifacts before rebuilding — a leftover // Rebuild native modules for target platform using prebuild-install.
// build/Release/*.node for the host platform must not survive. // prebuild-install supports cross-platform via --platform/--arch,
// unlike @electron/rebuild which only supports --arch.
// This is FATAL — a Linux .node in a Windows package is always broken.
const nativeModules = ['better-sqlite3']; const nativeModules = ['better-sqlite3'];
for (const mod of nativeModules) { for (const mod of nativeModules) {
const buildRelease = path.join(buildPath, 'node_modules', mod, 'build', 'Release'); const modDir = path.join(buildPath, 'node_modules', mod);
if (!fs.existsSync(modDir)) continue;
// Clean stale build artifacts — a leftover build/Release/*.node
// for the host platform must not survive.
const buildRelease = path.join(modDir, 'build', 'Release');
if (fs.existsSync(buildRelease)) { if (fs.existsSync(buildRelease)) {
fs.rmSync(buildRelease, { recursive: true, force: true }); fs.rmSync(buildRelease, { recursive: true, force: true });
console.log(`[forge] Cleaned stale build/Release for ${mod}`); console.log(`[forge] Cleaned stale build/Release for ${mod}`);
} }
}
// Rebuild native modules for target platform using @electron/rebuild. console.log(`[forge] Downloading ${mod} prebuilt for ${targetKey} (Electron ${electronVersion})...`);
// This is fatal — a Linux .node in a Windows package is always broken.
console.log(`[forge] Rebuilding native modules for ${targetKey} (Electron ${electronVersion})...`);
execSync( execSync(
`npx --yes @electron/rebuild --platform ${platform} --arch ${arch} ` + `npx --yes prebuild-install -r electron -t ${electronVersion} ` +
`--module-dir "${path.join(buildPath, 'node_modules')}" ` + `--platform ${platform} --arch ${arch} --tag-prefix v --verbose`,
`--electron-version ${electronVersion} ` + { cwd: modDir, stdio: 'inherit' },
`--only better-sqlite3`,
{ cwd: buildPath, stdio: 'inherit' },
); );
// Verify the downloaded binary is NOT an ELF (Linux) file.
// node-gyp-build loads from prebuilds/ first, then build/Release/.
const prebuildsTarget = path.join(modDir, 'prebuilds', targetKey);
if (fs.existsSync(prebuildsTarget)) {
for (const f of fs.readdirSync(prebuildsTarget)) {
if (f.endsWith('.node')) {
const buf = Buffer.alloc(4);
const fd = fs.openSync(path.join(prebuildsTarget, f), 'r');
fs.readSync(fd, buf, 0, 4, 0);
fs.closeSync(fd);
// ELF magic: 0x7f 'E' 'L' 'F'
if (buf[0] === 0x7f && buf[1] === 0x45 && buf[2] === 0x4c && buf[3] === 0x46) {
throw new Error(
`[forge] FATAL: ${mod} prebuilt for ${targetKey} is an ELF binary! ` +
`Cross-compilation failed — refusing to package a Linux .node for Windows.`,
);
}
console.log(`[forge] Verified ${f} is not ELF ✓`);
}
}
} else {
throw new Error(
`[forge] FATAL: No prebuilds/${targetKey}/ directory found for ${mod} after prebuild-install. ` +
`The native module would fall back to a Linux binary at runtime.`,
);
}
}
} }
// vectordb uses platform-specific optional deps (@lancedb/vectordb-<platform>-<arch>-*). // vectordb uses platform-specific optional deps (@lancedb/vectordb-<platform>-<arch>-*).